Fix to avoid null WebSocket messages
What does this MR do?
Since, a few days we get web socket messages like 42[null,{"m":null,"o":null}]
. These unfortunately cause a lot of crashes in the Android app. We currently do not have an idea where these messages are coming from.
As a first workaround this adds a null check to the chat server to avoid filter out these messages.
How confident are you it won't break things if deployed?
Very
Links to related issues
Slack Thread: https://yunity.slack.com/archives/C1T1ZM9A4/p1585088263106100
How to test
- Checkout branch locally
- Login as foodsaver
- Check that the WebSocket updates work normally (e.g. new bells and messages appear without a page reload)
Checklist
-
added a test, or explain why one is not needed/possible... -
no unrelated changes -
asked someone for a code review -
joined #foodsharing-beta channel at https://slackin.yunity.org -
added an entry to CHANGELOG.md (description, merge request link, username(s)) -
Once your MR has been merged, you are responsible to update the #foodsharing-beta Slack channel about what has been changed here. They will test your work in different browsers, roles or other settings