Skip to content

Improve vue register form

Christian Walgenbach requested to merge vue-register-form-v2 into master

Closes #522 (closed) #809 (closed) #782 (closed)

What does this MR do?

  • Insert a link (new tab) to the data protection agreement in the page from the birthdate.
  • Update dependencies vuelidate
  • Replaced Datepicker to sum.cumo/vue-datepicker
  • Switched to prop show-calendar-on-button-click in datepicker
  • Removed legal form
  • The legal agreement and data protection declaration is written into the database when registering.
  • The checkboxes (Datenschutzerklärung und Rechtsvereinbarung) at the end are graphically now the same.
  • Outsource each individual page into a child vue component.
  • Support for entering date of birth from EU format (25.12.2019) instead of US format (2019-12-25)
  • If the register fails, a error message from backend shows the reason.
  • Support for country code in mobile phone input field.
  • Moved register form to a own module

How confident are you it won't break things if deployed?

I tested all related changes in foodsaver module.

Links to related issues

#782 (closed)

How to test

Steps a reviewer can take to verify that this MR does what it says it does e.g.

  1. Checkout branch locally
  2. Click to "Mach mit!"
  3. Click to "Jetzt registrieren!"
  4. Fill field "E-Mail"
  5. Fill field "Passwort"
  6. Fill field "Passwortwiederholung"
  7. Click to "weiter"
  8. Click to a gender
  9. Fill field "Vorname"
  10. Fill field "Nachname"
  11. Click to "weiter"
  12. Fill field "birthdate" or use datepicker
  13. Click "weiter"
  14. Fill field "Handynummer"
  15. Click to "weiter"
  16. Check option "Rechtsvereinbarung"
  17. Check option "Datenschutzerklärung"
  18. Uncheck option "Newsletter"
  19. Click to "Anmeldung absenden"
  20. Check your inbox for registration mail
  21. Click to "Anmelden"
  22. Test the first login

Screenshots (if applicable)

Any relevant screenshots if this is a design / frontend change

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • joined #foodsharing-beta channel at https://slackin.yunity.org
  • added an entry to CHANGELOG.md (description, merge request link, username(s))
  • Once your MR has been merged, you are responsible to update the #foodsharing-beta Slack channel about what has been changed here. They will test your work in different browsers, roles or other settings
Edited by Christian Walgenbach

Merge request reports