Skip to content

Resolve "Expose development docker ports on all interfaces by default?"

Fridtjof requested to merge 800-expose-development-docker-ports-on-all-interfaces-by-default into master

Closes #800 (closed)

What does this MR do?

This merge request restricts most container ports that are proxied by Docker for the dev and test environment to localhost only. This is to prevent exposing admin interfaces (direct mysql connection, phpmyadmin, maildev, ...) to the network the dev machine is in

Exceptions are:

  • (dev) web - e.g. for developing mobile apps with real devices
  • (dev) client - same as web
  • (dev) chat - I am unsure if this can't just be locked down too - does a client ever talk to this service directly?

How confident are you it won't break things if deployed?

no chance, only affects the dev environment

Checklist

  • no test necessary, this does not touch code running in production
  • no unrelated changes
  • asked someone for a code review
  • added an entry to CHANGELOG.md (description, merge request link, username(s))
Edited by Chris Oelmueller

Merge request reports