home district added to fs_change_history - leaving home district removes verification
What does this MR do?
If a foodsaver leaves a Home District (Stammbezirk) by himself the verification is removed, the user is informed about it, and has to ask the an ambassador for verification. This process is logged in verification history and can be seen by an ambassador.
How confident are you it won't break things if deployed?
Very
Links to related issues
Moving is a rather rare occasion and you would know it in advance (it's nothing that happens "all of a sudden" or "unexpected"). It would only prevent you from making a new pickup (the ones you are already signed up for are not effected).
Especially Berlin was one of the reasons for this MR.
- "running away" from "Regelverletzungen" to a district where a bot is in more favor of you and the "Regelverletzung" doesn't get anywhere.
- Moving into another district where there can be custom rules, that the foodsaver is not aware of and should therefore contact the bots to be informed about it.
- Voting (not only in Berlin) is in some districts restricted to the "Stammbezirk" during the berlin Festival there where concerns that it could be abused to "fake" votes. (edited)
How to test
Steps a reviewer can take to verify that this MR does what it says it does e.g.
- Checkout branch locally
- Login as foodsaver
- Go to the forum of home district
- choose menue option "leave home district"
- Read the warning and Leave the district
- Login with ambassador
- Look at the history of the foodsaver (you can see that he lost verification because of himself)
- Verify foodsaver
Screenshots (if applicable)
Warning by leaving the district :
Ambassador can see on verification that user lost his verification and also recorded in history:
For ambassadors it is shown who changed the last home district entry.
Checklist
-
added a test, or explain why one is not needed/possible... -
no unrelated changes -
asked someone for a code review -
joined #foodsharing-beta channel at https://slackin.yunity.org -
added an entry to CHANGELOG.md (description, merge request link, username(s)) -
Once your MR has been merged, you are responsible to update the #foodsharing-beta Slack channel about what has been changed here. They will test your work in different browsers, roles or other settings