Remove Sessions from Gateway-Classes
What does this MR do?
Refactoring: As mentioned here, for better testability Sessions should not be used in Gateway classes. This as an entry level task assigned to me by Jo. https://gitlab.com/foodsharing-dev/foodsharing/-/wikis/Best-practices-for-gateways
BlogGateway class is currently in @jofranz's pipeline, so I did not touch it.
How confident are you it won't break things if deployed?
Update: Pretty confident now. I'm able to debug locally now and could see no further issues.
Links to related issues
https://gitlab.com/foodsharing-dev/foodsharing/-/wikis/Best-practices-for-gateways
How to test
Steps a reviewer can take to verify that this MR does what it says it does e.g.
Unit tests should not be necessary, as I did not add any functionality. The existing tests still work
- Checkout branch locally
- Login as foodsaver
- Go to any user's profile page, try the different actions (rate, blame etc) on the user page
Screenshots (if applicable)
Not relevant - refactoring
Checklist
-
added a test, or explain why one is not needed/possible... -
no unrelated changes -
asked someone for a code review -
joined #foodsharing-beta channel at https://slackin.yunity.org -
added an entry to CHANGELOG.md (description, merge request link, username(s)) -
Once your MR has been merged, you are responsible to update the #foodsharing-beta Slack channel about what has been changed here. They will test your work in different browsers, roles or other settings
Edited by Alex