Moved function getSessions to listSessions in function getSessionListContent (QuizControl.php)
What does this MR do?
Moved function getSessions to listSessions in function getSessionListContent (QuizControl.php)
https://sentry.io/share/issue/4869808bd57e4d14b5ebae01b5ef2740/
Release blocking if not fixed for #747 (closed)
How confident are you it won't break things if deployed?
I can reproduce the behavior and after changing the function, as described by @jo, the behavior is no longer reproducible.
Links to related issues
How to test
Steps a reviewer can take to verify that this MR does what it says it does e.g.
- Checkout branch locally
- Login as amb (bot)
- Open "Auswertung für Quiz #1-Quiz"
- Click to foodsaver name to open a quiz session
- Delete the quiz session
- Open "Auswertung für Quiz #1-Quiz" again
Screenshots (if applicable)
This error message is showing, if a quiz session is deleted and "Auswertung für Quiz" is reloaded:
After update function getSessions to listSessions is no error showing:
Checklist
-
added a test, or explain why one is not needed/possible... -
no unrelated changes -
asked someone for a code review -
joined #foodsharing-beta channel at https://slackin.yunity.org -
added an entry to CHANGELOG.md (description, merge request link, username(s)) -
Once your MR has been merged, you are responsible to update the #foodsharing-beta Slack channel about what has been changed here. They will test your work in different browsers, roles or other settings
Edited by Johannes