Remove moment dependency from conversations.js
Closes #678 (closed)
What does this MR do?
Removes the only "production" dependency to momentjs which is a transitive dependency of a dev dependency. According to https://beta.foodsharing.de/assets/bundlesize.html it is not the smalles dependency and not really required.
How confident are you it won't break things if deployed?
Tested it, still works.
Links to related issues
- https://beta.foodsharing.de/assets/bundlesize.html
- https://yunity.slack.com/archives/CRAUWEV4Y/p1578197388000100
How to test
- Start locally.
- Sign in as one user.
- Open a second tab (privacy mode) and log in as a different user.
- Write a message to the other user and check the times in the top menu.
Screenshots (if applicable)
Checklist
-
added a test, or explain why one is not needed/possible... -
no unrelated changes -
asked someone for a code review -
joined #foodsharing-beta channel at https://slackin.yunity.org -
added an entry to CHANGELOG.md (description, merge request link, username(s)) -
Once your MR has been merged, you are responsible to update the #foodsharing-beta Slack channel about what has been changed here. They will test your work in different browsers, roles or other settings
Edited by Alex