Refactor RegionGateway
What does this MR do?
Refactors some things in the RegionGateway
classes: use prepared queries wherever possible, renamed parameters and added their types.
There are quite a lot of changes, but ideally nothing should change except for the code being a bit clearer.
How confident are you it won't break things if deployed?
Quite sure, tests work.
How to test
Steps a reviewer can take to verify that this MR does what it says it does e.g.
- Checkout branch locally
- Login as foodsaver
- Do anything that has to do with a region
Checklist
-
added a test, or explain why one is not needed/possible... same tests as before -
no unrelated changes -
asked someone for a code review -
joined #foodsharing-beta channel at https://slackin.yunity.org -
added an entry to CHANGELOG.md (description, merge request link, username(s)) -
Once your MR has been merged, you are responsible to update the #foodsharing-beta Slack channel about what has been changed here. They will test your work in different browsers, roles or other settings
Edited by Alex