Skip to content

Newsletters to send are counted properly

Caluera requested to merge caluera-count-refactoring into master

Closes None

What does this MR do?

This MR fixes a bug which used the variable name as a string instead of the variable itself. The remaining emails to be sent are now counted

How confident are you it won't break things if deployed?

Pretty much, it is only a small change

Links to related issues

Bug was found here !1273 (comment 265977097)

How to test

Steps a reviewer can take to verify that this MR does what it says it does e.g.

  1. Checkout branch locally
  2. Login as orga
  3. sent a newsletter
  4. see that the number of mails to send goes down

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • joined #foodsharing-beta channel at https://slackin.yunity.org
  • added an entry to CHANGELOG.md (description, merge request link, username(s))
  • Once your MR has been merged, you are responsible to update the #foodsharing-beta Slack channel about what has been changed here. They will test your work in different browsers, roles or other settings
Edited by Caluera

Merge request reports