Skip to content

Create store message points to wrong profile url

Caluera requested to merge calu-new-store-correct-profile-link-on-pinwall into master

Closes #512 (closed)

What does this MR do?

When a store is newly created, there is a post on the pinwall with the information who created the store when. Before the link to the profile missed the foodsaver Id and thus did not lead to the profile. Now the link is complete because a superfluous " is removed.

How confident are you it won't break things if deployed?

Very, I deleted only one " and it works locally.

Links to related issues

Any relevant links (issues, documentation, slack discussions).

How to test

Steps a reviewer can take to verify that this MR does what it says it does e.g.

  1. Checkout branch locally
  2. Login as foodsaver
  3. Go to a store.
  4. Look at the very first pinwall entry.
  5. Click on the name.
  6. It should lead you to the profile of the foodsaver who created the store.

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • joined #foodsharing-beta channel at https://slackin.yunity.org
  • added an entry to CHANGELOG.md (description, merge request link, username(s))
  • Once your MR has been merged, you are responsible to update the #foodsharing-beta Slack channel about what has been changed here. They will test your work in different browsers, roles or other settings
Edited by Chris Oelmueller

Merge request reports