Caluera count refactoring
Closes None
What does this MR do?
The following functions:
- getUnconfirmedFetchesCount
- getMailsLeft
- getViolationCount
- deleteGroup
were refactored such that the count function was used instead of the current more complicated expressions.
How confident are you it won't break things if deployed?
There are tests for a part of the changes and they work. And I tried it locally, which also worked.
Links to related issues
Any relevant links (issues, documentation, slack discussions).
How to test
Steps a reviewer can take to verify that this MR does what it says it does e.g.
- Checkout branch locally
- Login as foodsaver
- Check if: the number of unconfirmed fetches is correct, the number of violations in a profile is correct
Checklist
-
added a test, or explain why one is not needed/possible... -
no unrelated changes -
asked someone for a code review -
joined #foodsharing-beta channel at https://slackin.yunity.org -
added an entry to CHANGELOG.md (description, merge request link, username(s)) -
Once your MR has been merged, you are responsible to update the #foodsharing-beta Slack channel about what has been changed here. They will test your work in different browsers, roles or other settings
Edited by Chris Oelmueller