Skip to content

Fix unrendered links in FAQ

Alex requested to merge 531-fix-faq-hyperlinks into master

Closes #531 (closed)

What does this MR do?

Removes strip_tags from the FAQAdminGateway when saving a FAQ entry, so that links will be rendered. Since that is only accessible for orga, this shouldn't be a security problem (it's done the same way in ContentModule).

After this the links have to be recreated for the rendering to take effect.

How confident are you it won't break things if deployed?

Very.

Links to related issues

See discussion in the issue: #531 (comment 229766692)

How to test

  1. Login as orga
  2. Go to the FAQ admin tool (Administration -> FAQ verwalten)
  3. Edit an entry and add a link to it

Checklist

  • added a test, or explain why one is not needed/possible... can be tested manually
  • no unrelated changes
  • asked someone for a code review
  • joined #foodsharing-beta channel at https://slackin.yunity.org
  • added an entry to CHANGELOG.md (description, merge request link, username(s))
  • Once your MR has been merged, you are responsible to update the #foodsharing-beta Slack channel about what has been changed here. They will test your work in different browsers, roles or other settings
Edited by Alex

Merge request reports