Skip to content

Replace REPLACE INTO queries

Alex requested to merge 757-replace-replace into master

Part of #757 (closed)

What does this MR do?

Replaces some of the REPLACE INTO queries with prepared statements by INSERT ... ON DUPLICATE KEY UPDATE (Database.insertOrUpdate) which seems to do the same.

How confident are you it won't break things if deployed?

Quite sure. I added simple unit tests

Links to related issues

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • joined #foodsharing-beta channel at https://slackin.yunity.org
  • added an entry to CHANGELOG.md (description, merge request link, username(s))
  • Once your MR has been merged, you are responsible to update the #foodsharing-beta Slack channel about what has been changed here. They will test your work in different browsers, roles or other settings
Edited by Chris Oelmueller

Merge request reports