Skip to content

Fixes query to update large work group teams

David requested to merge fix-update-large-work-group into master

May fix #726 (closed)

What does this MR do?

To update a work group team currently a query is generated which delete all team members NOT IN(...) the new list of team members. For very large work groups this causes the issue that the query can not be prepared since it gets too large (e.g. https://sentry.io/share/issue/d76268f9c445459a94addd017b248961/).

With this MR, first the list of current members is fetched and the diff is calculated in PHP.

How confident are you it won't break things if deployed?

Very, tested different edge cases locally.

Links to related issues

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • joined #foodsharing-beta channel at https://slackin.yunity.org
  • added an entry to CHANGELOG.md (description, merge request link, username(s))
  • Once your MR has been merged, you are responsible to update the #foodsharing-beta Slack channel about what has been changed here. They will test your work in different browsers, roles or other settings

Merge request reports