Skip to content

Fix "expected one or more results"-exception when fetching stores' conversation IDs

Sven Oos requested to merge Fix-Expected_one_or_more_results_exception-in-StoreModel_getBetriebConversation into master

What does this MR do?

There were some test data seeds that caused a "Expected one or more results, but none was returned." in Database->fetchValue(...) caused be StoreGateway->getBetriebConversation(...). I extended the gateway's function to return a int value of 0 if the store does not exist or the id value would be null. I also renamed the function to getStoreConversationId(...).

How confident are you it won't break things if deployed?

confident

Links to related issues

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • joined #foodsharing-beta channel at https://slackin.yunity.org
  • added an entry to CHANGELOG.md (description, merge request link, username(s))
  • Once your MR has been merged, you are responsible to update the #foodsharing-beta Slack channel about what has been changed here. They will test your work in different browsers, roles or other settings

Merge request reports