Open landing page video in new tab with confirmation dialog (!1177) · Merge requests · foodsharing-dev / foodsharing · GitLab

The 17.0 major release is coming on May 16, 2024! This version brings many exciting improvements to GitLab, but also removes some deprecated features. We are introducing three breaking change windows during which we expect breaking changes to be deployed to GitLab.com. You can read more about it on our blogpost . The third breaking change window begins 2024-05-06 09:00 UTC and ends 2024-05-08 22:00 UTC.

David requested to merge start-video into master Nov 12, 2019

Closes #617 (closed)

What does this MR do?

Instead of embedding the video into the page, clicking on the video preview open the video in a new tab.

To inform users that they are leaving our page and are redirect to youtube a confirmation dialog is shown before opening the new tab:

How confident are you it won't break things if deployed?

Very

Links to related issues

Checklist

added a test, or explain why one is not needed/possible...
no unrelated changes
asked someone for a code review
joined #foodsharing-beta channel at https://slackin.yunity.org
added an entry to CHANGELOG.md (description, merge request link, username(s))
Once your MR has been merged, you are responsible to update the #foodsharing-beta Slack channel about what has been changed here. They will test your work in different browsers, roles or other settings