Skip to content

Location error check related change

Johannes requested to merge Jo-use-empty-for-lat-lon-zero-check into master

What does this MR do?

Location error check related change

  • Replace $var == 0 by empty()
  • Fail if either $lat OR $lon is empty

This also could accidentally fix "null-island" and "arctic-null" location problems. You can see it by zooming completly out and enabling every store settings on your map.

How confident are you it won't break things if deployed?

Didn't test it but should work

Links to related issues

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • joined #foodsharing-beta channel at https://slackin.yunity.org
  • added an entry to CHANGELOG.md (description, merge request link, username(s))
  • Once your MR has been merged, you are responsible to update the #foodsharing-beta Slack channel about what has been changed here. They will test your work in different browsers, roles or other settings

Merge request reports