Skip to content

Check whether basket request form container exists before intializing vue component

David requested to merge fix-basket-request-form-vue-not-found-error into master

Fixes https://sentry.io/organizations/foodsharing-ev/issues/1042125057/?project=1400918

What does this MR do?

In !1121 (merged) I added a new vue component on the basket detail page. It is only shown if the current user is not the offerer of the basket but it is always initialised in basket.js. Now it is checked whether the container actually exists before initialising the vue component.

How confident are you it won't break things if deployed?

Very

Links to related issues

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • joined #foodsharing-beta channel at https://slackin.yunity.org
  • added an entry to CHANGELOG.md (description, merge request link, username(s))
  • Once your MR has been merged, you are responsible to update the #foodsharing-beta Slack channel about what has been changed here. They will test your work in different browsers, roles or other settings
Edited by Chris Oelmueller

Merge request reports