Skip to content

Enable pickup-list for foodsavers own profile in profile view

Johannes requested to merge JO-enable-pickups-in-profile-view into master

Closes #636 (closed)

What does this MR do?

Enable pickup-list for foodsavers own profile in profile view which was only visible for ambassadors/"BOTs" before. Got very easy thanks to @peter.toennies !1037 (merged) profile refactor/cleanup. Thx! Other than that this is nothing to be proud of as it touches a lot of old code which I usually advice against, but it helps a lot of people with a component which is already being used. So why should we hide it?

Profile:
https://beta.foodsharing.de/profile/XXXXXX

Regular list (previously ambassador/"BOT" only) list-bot

Own profile for all foodsavers list-fs

How confident are you it won't break things if deployed?

Should work

Links to related issues

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • joined #foodsharing-beta channel at https://slackin.yunity.org
  • added an entry to CHANGELOG.md (description, merge request link, username(s))
  • Once your MR has been merged, you are responsible to update the #foodsharing-beta Slack channel about what has been changed here. They will test your work in different browsers, roles or other settings
Edited by Chris Oelmueller

Merge request reports