See: !1309 Refactor register form to multi step pages in vue
- Closes #540 (closed)
- Closes #680 (closed)
- Closes #723 (closed)
- Closes #653 (closed)
What does this MR do?
We have a lot of support tickets where users can not fully complete the registration.
- With the help of @alangecker commit the register form is built in vue.
- HTML template in RegisterForm.vue extended with all fields
- The address search removed because implementation is not so easy and after consultation in the dev channel as a foodsharer is not necessary.
- Use contentGateway for legal info.
Which fields should be mandatory fields?
- Password (minimum length 8 characters)
- First given name?
- Gender
- Surname?
- Date of birth?
ToDos:
-
A working validation for page 1 (mail and password) -
A working validation for page 2 (firstname and lastname) -
A working validation for birthdate -
Redirect to login form after a successful register. -
Remove old register code -
Remove old validation code -
Create php unit tests
How confident are you it won't break things if deployed?
I'm not sure since I'm still a beginner. However, it was very tested by @jofranz @fs_k.
Links to related issues
How to test
Steps a reviewer can take to verify that this MR does what it says it does e.g.
- Checkout branch locally
- Click to "Mach mit!"
- Click to "Jetzt registrieren!"
- Fill field "E-Mail"
- Fill field "Passwort"
- Fill field "Passwortwiederholung"
- Click to "weiter"
- Click to a gender
- Fill field "Vorname"
- Fill field "Nachname"
- Click to "weiter"
- Fill field "birthdate"
- Click "weiter"
- Fill field "Handynummer"
- Click to "weiter"
- Check option "Rechtsvereinbarung"
- Check option "Datenschutzerklärung"
- Uncheck option "Newsletter"
- Click to "Anmeldung absenden"
- Check your inbox for registration mail
- Click to "Anmelden"
- Test the first login
Screenshots (if applicable)
Checklist
-
added a test, or explain why one is not needed/possible... -
no unrelated changes -
asked someone for a code review -
joined #foodsharing-beta channel at https://slackin.yunity.org -
added an entry to CHANGELOG.md (description, merge request link, username(s)) -
Once your MR has been merged, you are responsible to update the #foodsharing-beta Slack channel about what has been changed here. They will test your work in different browsers, roles or other settings
Edited by Chris Oelmueller