Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
fdroidserver
fdroidserver
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 249
    • Issues 249
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 16
    • Merge Requests 16
  • Requirements
    • Requirements
    • List
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • CI / CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • External Wiki
    • External Wiki
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • F-Droid
  • fdroidserverfdroidserver
  • Merge Requests
  • !821

Merged
Opened Oct 22, 2020 by Hans-Christoph Steiner@eighthaveOwner

purge aapt requirements and elevate apksigner

  • Overview 0
  • Commits 9
  • Pipelines 1
  • Changes 10

This removes aapt parsing code everywhere where it can be entirely replaced by androguard v3.3.3+. aapt support is still included as an opportunistic fallback for reading the Application ID and Version Code from APKs. APKs can do some very weird things, at the very least, fdroid update should be able to find their Application ID and Version Code.

fdroid init then prioritizes finding apksigner and enabling that so that v2/v3 signatures verify.

More details in the commit messages. I'm running a test of the buildserver changes on verification.

@Bubu @uniqx

Edited Oct 22, 2020 by Hans-Christoph Steiner
Assignee
Assign to
Reviewer
Request review from
2.0
Milestone
2.0 (Past due)
Assign milestone
Time tracking
Reference: fdroid/fdroidserver!821
Source branch: purge-aapt