Skip to content

remove redundant google analytics match

Mike Hardy requested to merge (removed):patch-2 into master

Related to admin#144 (comment 239230000)

The regex in fdroidserver should be fixed to avoid false positives

The false positive is libre analytics library 'net.mikehardy:google-analytics-java' and 'net.mikehardy:google-analytics-java7'

'google.*play.*services' and 'firebase' will already catch all manners of including analytics I think

https://developers.google.com/android/guides/setup#split - specifies 'com.google.android.gms:play-services-analytics'

https://firebase.google.com/support/release-notes/android#latest_sdk_versions - specifies 'com.google.firebase:firebase-analytics'

This is not intended to be controversial though. If there are doubts I would suggest these other ways:

1- prefixing the regexes with 'com.', so keeping it but saying 'com.google.*play.*services' and/or 'com.google.analytics.' 2- maybe whitelisting this specific library?

Merge request reports