Skip to content

metadata: refactor parsing normalization

Hans-Christoph Steiner requested to merge eighthave/fdroidserver:normalize-type-list-int into master

This merge request is a follow up on !1350 (merged), done while in process with that. It is about refactoring the code, mapping out the existing behaviors, and making predictable conversions. With this merge request, I do not aim to solidify the type conversions more, I'm still open to discussing if we want them, and where.

The tests in PostMetadataParseTest show the current conversions. I think it is clear that this merge request makes those responses more consistent, e.g. TYPE_LIST App and Build fields are now converted in the same way. Or values that are valid in a Build field are valid in an App field. I think this will make it easier for metadata maintainers. It will make things easier for fdroidserver maintainers.

More details in the commit messages. I recommend reviewing one commit at a time.

  • Once this is ready to merge, I'll update the commit in the metadata_v0 test to fix that.
Edited by Hans-Christoph Steiner

Merge request reports