Skip to content

remove last `maven:` quirks and make it always a string

Hans-Christoph Steiner requested to merge eighthave/fdroidserver:remove-last-maven-quirks into master

It turns out that the maven: field was originally declared as a TYPE_STRING, given that it was not given a different type in metadata.py's flagtypes. The code was confused because it was given a default value of False rather than None as the rest of the TYPE_STRING fields have.

This construct in build.py means maven: should always be a string:

        if '@' in build.maven:
            maven_dir = os.path.join(root_dir, build.maven.split('@', 1)[1])
        else:
            maven_dir = root_dir

This includes a test case for the maven: field and a deploy test case I had lying around for a while now.

Edited by Hans-Christoph Steiner

Merge request reports