Palm Calc 2019+
-
The app complies with the inclusion criteria -
The original app author has been notified (and supports the inclusion) -
All related fdroiddata and rfp issues have been referenced in this merge request -
Builds with fdroid build
Hello, this is my first time submitting.
This app is a revival of PalmCalc, which was archived due to using an old signing key.
I mostly just want to see this useful app back on the store with a secure signing key, but I'll add features when I can.
-
fdroid readmeta -W warn
passes -
fdroid lint -W warn
passes -
fdroid rewritemeta -W warn
has been run -
fdroid checkupdates -W warn
has been run and committed
the -W flag is needed to get past metadata issues from others, see below
Gradle definition
the fdroid
command calls the global gradle
command instead of the project-local wrapper.
Not sure if this is by design. Normal practice (AFAIK) is to call the bundled gradle wrapper with ./gradlew
, which downloads the right version.
I had to add my own downloaded copy of the right Gradle version to PATH to get past this.
Metadata Issue from Others
Running fdroid lint com.github.palmcalc2019.palmcalc
produces:
'bc1qu482c0tngkcvx3q7mrm8zmuldrh2f2lrh26ym0' is not a valid Bitcoin address in org.projectmaxs.main
this isn't caused by my metadata add.
I suppressed this with -W warn
, as mentioned above.
Unknown Issue with Build
fdroid build -w -l -W warn
produced the following error:
TypeError: add() got an unexpected keyword argument 'exclude'
The app builds fine in my local dev environment.
I'm using fdroidserver 1.0.9 from mac homebrew, and I see the master
repo version is closer to 1.2.0, so maybe the problem is an old version.
I did follow your guide to set up a python virtual environment, and ran that version of fdroid
,
but it produced another Gradle path error, this time seemingly python-specific - that I didn't know how to fix:
OSError while trying to execute /Users/adamh/src/fdroidserver-env/lib/python3.6/site-packages/gradlew-fdroid clean: [Errno 2] No such file or directory: '/Users/adamh/src/fdroidserver-env/lib/python3.6/site-packages/gradlew-fdroid': '/Users/adamh/src/fdroidserver-env/lib/python3.6/site-packages/gradlew-fdroid
I have no experience or interest in setting up a Docker environment to try that version, so I'm deferring to you the experts.
Hopefully you can tell me what I'm wrong, because I have another app I'd like to submit after this one.
I recommend creating a "medium difficulty" app-submission procedure for people who are happy filling out a YAML form, but not happy getting into the nitty-gritty of building a dev copy of fdroidserver
.
Apologies if any of this seems rude or presumptuous. I imagine that you are all volunteers, like me. So thanks for your time & effort, building & maintaining an amazing app store.