Skip to content

Draft: Standardize URL handling

Angus Gratton requested to merge projectgus/fdroidclient:bugfix/repo_url_querystring into master

Partial fix for #2078 (closed) - case when a repo URL is incorrectly added with an embedded querystring (like fingerprint=) still in the URL field. The repo verifies correctly on update but nothing can be downloaded from it.

More details in the linked issue.

Thanks for all your work on FDroid. :). Of course let me know if you would like any changes.

TODOs

  • Add tests for URL index & APK formatting
  • Update formatting to be consistent
  • Add tests for icons and possibly similar repo file types
  • Figure out how to handle Android content URL format

Deferred to later MR

Originally this MR included a fix for adding new repo URLs in the UI as well (for issue #2078 (closed)), but this has been removed and will be submitted in a later MR. The case of a URL being already added to the database with a querystring in it is fixed in this MR, though.

Edited by Angus Gratton

Merge request reports