Skip to content

Fix displaying default icon for apps without icons

Dmitriy Bogdanov requested to merge di72nn/fdroidclient:fix_null_icons_in_list into master

There's this minor bug that's been bothering me for a while: if an app doesn't have an icon it gets displayed with a random icon (due to view recycling).

Steps to reproduce:

  • Open "Search apps", enter "wallet".
  • "Groestlcoin Wallet", "Bitcoin Wallet", "Bitcoin Wallet [testnet3]" are displayed with random icons (opening detailed view for any of them shows the "default" icon).
  • Go back to the main list.
  • Open "Search apps" again, enter "wallet".
  • The same three wallet apps have different random icons.

There are other apps that exhibit the same problem, like org.fdroid.fdroid.ota_1001050.

My changes basically reproduce the logic in ImageLoader.getInstance().displayImage(...) so the behavior is consistent if DisplayImageOptions changes.

Edited by Dmitriy Bogdanov

Merge request reports