Skip to content

waiting Period + tests

dju requested to merge waitingPeriod into master

Feature Merge Request (MR)

What does this MR add?

closes #4 (closed)

after the end of the epoch there is a waitingPeriod during which

  • tickets from the old epoch can still be submitted
  • tickets from the new epoch can not be submitted

after the end of the waitingPeriod

  • tickets from the old epoch can still be submitted
  • but also endEpoch can be called

Also, endTime did not actually reflect when an assessment ended (just when it absolutely needed to end). I changed it so that it is being set to now when the result is calculated.

Complications

  • We need to require that the assessment was actually finished (and not cancelled, while the assessor was in state DONE). As assessments are no longer destroyed upon cancellation, we need to find a new way of seeing that. Suggestions @jaredpereira

chekcing whether finalScore !=0? setting endTime to some predefined value (e.g. 0?)

  • Another implication of our design that came to my mind is that if there is a stale period on the network, one has to potentially call endEpoch a bunch of times in order to be able to submit a ticket. In that case, we prob. want to only mint tokens if there is a nonzero winner.
Edited by dju

Merge request reports