Update dependency magento/magento-coding-standard to v17 - abandoned
This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| magento/magento-coding-standard | require-dev | major |
^6 -> ^17
|
Release Notes
magento/magento-coding-standard
v17
New rules
- AC-1060: Move relevant sniffs from phpcompatibility by @svera
- AC-391: Static test to cover "deprecated" jQuery methods by @Rrego6
- Fixed graphql unit test failing as it was extending from a wrong class by @svera
- AC-1717: Passing null to non-nullable internal function parameters is deprecated by @svera
- AC-1718 return types for arrayaccess methods by @svera
Improvements
- AC-99: Update Third Party library: jquery.tabs by @krissyhiserote
- Allow use of modern syntax in JavaScript files by @fredden
- Run tests on php 8.1 by @ihor-sviziev
- Simplify file structure for ESLint ruleset by @fredden
- Disallow Yoda Conditions in JavaScript files by @fredden
Fixes
- Fix DirectThrowSniff false positive by @rmsundar1
v16
New Rules
- Created Sniff to validate function which usage without arguments is deprecated in PHP 8.1 https://github.com/magento/magento-coding-standard/pull/325 by @anzin
- Added deprecated function PHP 8.1 to DiscouragedFunctionSniff https://github.com/magento/magento-coding-standard/pull/326 by @anzin
- Added PSR12.Properties.ConstantVisibility rule to the ruleset https://github.com/magento/magento-coding-standard/pull/330 by @rmsundar1
- AC-1059: Included PHPCompatibility rules https://github.com/magento/magento-coding-standard/pull/332 by @svera
Improvements
- Updated rule names for better, more granular messaging https://github.com/magento/magento-coding-standard/pull/328 by @fredden
- AC-1740: Added RectorPHP and included it as part of the GitHub actions https://github.com/magento/magento-coding-standard/pull/333 by @eliseacornejo
Fixes
- Fixed code ArrayAutovivificationSniff for specific code constructions https://github.com/magento/magento-coding-standard/pull/329 by @anzin
- Fix GraphQL sniffs unit tests https://github.com/magento/magento-coding-standard/pull/334 by @eliseacornejo
- Fixed AutogeneratedClassNotInConstructorSniff for specific code constructions https://github.com/magento/magento-coding-standard/pull/336 by @sivaschenko
- Added support of PHP Attributes to the method annotation sniff https://github.com/magento/magento-coding-standard/pull/335 by @karyna-tsymbal-atwix
v15
New Rules
Improvements
- Excluded JS files for PSR sniffs in #324 by @sivaschenko
- AC-1509: Removed deprecated JSCS package in #327 by @loginesta
v14
New Rules
- AC-681: Create phpcs static check for PhtmlTemplateTest in #306 by @eliseacornejo
- AC-683: Create phpcs static check for TableTest in #309 by @svera
- AC-676: Create phpcs static check for ObsoleteConnectionTest in #310 by @eliseacornejo
- AC-670: phpcs layouttest in #298 by @svera
- AC-678: Create phpcs sniff for ObsoleteResponseTest in #311 by @eliseacornejo
- AC-663: PHPCS classes test in #274 by @svera
- AC-672: Create phpcs static check for LicenseTest in #312 by @eliseacornejo
- Added copyright verification for graphqls files in #321 by @sivaschenko
Improvements
- AC-1167: Add all filesystem PHP native functions covered by Filesystem\DriverInterface to DiscouragedFunctionSniff in #308 by @loginesta
- AC-206: Create UCT phpcs ruleset for customizations only in #313 by @svera
- AC-1549: Create codes for each type of returned error / warning in #316 by @svera
Fixes
- AC-1314: Fix copyright sniff for less files in #284 by @eliseacornejo
- Fixed undefined index in Magento2.Commenting.ClassPropertyPHPDocFormatting in #317 by @sivaschenko
- Extracted js tests to a separate build in #318 by @sivaschenko
- Fixed undefined variable error in AutogeneratedClassNotInConstructorSniff in #319 by @sivaschenko
v13
New rules
- AC-679 Create phpcs static check for ObsoleteSystemConfigurationTest by @eliseacornejo
- AC-682 Create phpcs static check for RestrictedCodeTest by @svera
- AC-679 Create phpcs static check for ObsoleteSystemConfigurationTest by @eliseacornejo
- AC-677 Create phpcs static test for ObsoleteMenuTest by @loginesta
- AC-674 Create phpcs static check for ObsoleteAclTest by @loginesta
- AC-667 Create phpcs static check for EmailTemplateTest by @jcuerdo
Other
- AC-1159 Remove eslint tests from magento2 repo and reuse new version of magento-coding-standard instead by @loginesta
- AC-1355 Move JSCS into magento-coding-standards repo by @loginesta
v12
Fixes
- AC-1339: Detect comment for typed class properties by @svera
- AC-669: Fixed directory name checking too lax by @svera
v11
New rules
- AC-1102: Static test to verify self-closing tags for non-void html elements by @xmav
- AC-662: Create phpcs static check for AutogeneratedClassNotInConstructorTest by @jcuerdo
- AC-1156: Move custom eslint tests to magento-coding-standard repo by @loginesta
- AC-665: Create phpcs static check for ConfigTest by @svera
- AC-669: Create phpcs static check for InstallUpgradeTest by @svera
Fixes
- AC-1307: PHP Syntax errors in xml files by @eliseacornejo
- AC-1335: Exclude the copyright sniff by @eliseacornejo
v10
New Rules
- Added sniff detecting obsolete email directives in #261 by @jcuerdo
- Added sniff detecting obsolete widget configurations in #266 by @jcuerdo
- Added sniff checking for correct copyright headers in #267 and #269 by @eliseacornejo
Fixes
v9
New Rules
- Added sniff to ensure proper sniff for class properties PHPDoc formatting in #140 by @konarshankar07
- Test moved from magento2: sniff looking for occurrences of obsolete
activeandversionattributes in themodule.xmlfile in #230 by @svera - Test moved from magento2: sniff looking for occurrences of obsolete nodes:
param,instance,array,item[@​key]andvaluein di.xml in #233 by @loginesta
Improvements
- Added
evalandproc*functions to theInsecureFunctionSniffclass by @orsinijose - Updated html, less and annotation rules severity in #255 by @eliseacornejo
- Improved less verification by catching newlines in the middle of a style definition in #258 by @svera
- Ignore PHPUnit results cache file in #254 by @fredden
Fixes
- Fixed fatal error when docblock includes parametry type but is missing the parameter name in #256 by @fredden
Test coverage
- Created unit test for Magento2\Less\SemicolonSpacingSniff in #253 by @loginesta
- Createe unit test for Magento2\Less\ColourDefinitionSniff check in #238 by @svera
- Created unit test for Magento2\Less\QuotesSniff check in #248 by @svera
- Created unit test for CombinatorIndentationSniff in #249 by @svera
- Created unit test for Magento2\Less\TypeSelectorsSniff in #250 by @svera
- Created unit test for Magento2\Less\ZeroUnitsSniff in #251 by @svera
- Created unit test for Magento2\Less\PropertiesLineBreakSniff in #244 by @svera
- Created unit test for Magento2\Less\TypeSelectorConcatenationSniff check in #247 by @loginesta
- Created unit test for Magento2\Less\VariablesSniff in #252 by @loginesta
- Created unit test for Magento2\Less\ColonSpacingSniff in #237 by @svera
- Created unit test for Magento2\Less\BracesFormattingSniff in #236 by @svera
v8
Fixes
- Fixed ImportsFromTestNamespace from lock on group use with trailing comma @fsw
- Moved abstract unit test to autoload-dev @sivaschenko
- Unit test coverage and fixes for HTML, annotation and less sniffs @eliseacornejo
v7
New Rules
- Added sniff to ensure correct usage of getChildHtml and getChildChildHtml AbstractBlock methods @eliseacornejo
- Annotation, Html and Less sniffs has been moved from the magento/magento2 repo @loginesta
Fixes
- Avoid infinite loop when Parse Error occurs @fredden
- Fix TypeError for phpcs->addWarning() @fredden
- Fixed HtmlDirectiveSniff @asheem-patro
- Add test coverage for HtmlBindingSniff @ihor-sviziev
- Moved parameter and variable tokenizers from the magento/magento2 repo @edspc
Infrastructure and updates
- Github Actions are now used to validate pull requests @ihor-sviziev
- All dependencies have been updated to the latest versions. The package is now PHP 8 compatible. @andrewbess @drpayyne
Configuration
-
If you want to rebase/retry this MR, click this checkbox.
This MR has been generated by Renovate Bot.
Edited by Anthony Barré