Skip to content

Issue 6758 - Made tooltips open on click

Thomas Greinerrequested to merge
ThomasGreiner-eyeo/abp/ui/adblockplus:issue_6758 into release-2018-4

This MR for https://gitlab.com/eyeo/adblockplus/adblockplusui/issues/106 contains the following changes:

  • Introduced <io-popout> component for tooltips and context menu
  • Added CSS variables to keep track of dependencies between elements
  • Added close button to tooltips
  • Made styles and logic between tooltips and context menus consistent
  • Fixed: Anchor pointer design was inconsistent with spec
  • Fixed: Tooltips now open on click
  • Smoke tests for:
    • Tooltip at top edge of viewport with short text
    • Tooltip at bottom edge of viewport with long text
    • Context menu with short text and custom content

This MR does not contain the following:

  • Keyboard-accessibility: This is not a regression
  • Transitions: This would've required a few more changes to get them working again
Edited by Thomas Greiner

Merge request reports