Update adblockplusui dependency to 85d7e0d5facd (release-2019-2)

Background

We'd like to update the adblockplusui dependency to include the recent user interface work in time for the upcoming 3.8 release.

What to change

  • Update adblockplusui dependency to hg:85d7e0d5facd git:541b886 (changes imported).
  • Add a singlePage flag to the "filters.unwhitelist" and "filters.whitelist" messages (see ui#499 and #77 (closed)). If true:
    • "filters.whitelist" should generate a whitelisting filter for the whole URL instead of just the hostname. See this code from the legacy Firefox extension.
    • "filters.unwhitelist" should remove all whitelisting filters which apply to the page which are more specific than just a hostname.
  • Adjust the "filters.isWhitelisted" to return an Object like {hostname: true, page: false} to indicate if the page or hostname is whitelisted (see ui#647).
  • To get the blocked counter to update in the popup window (see ui#634):
    • Adjust the 60 second customSave workaround for the "blocked_total" preference, so that it only applies to Firefox versions < 66.
    • Adjust the onConnect function in lib/filterConfiguration.js to no longer assume that uiPort.sender and uiPort.sender.tab exist. Adjust the corresponding code to handle the lack of senderTabId. This is necessary since messages sent by the popup window aren't associated with a tab.
  • Add this file mapping for info-big.svg (see ui#424):
skin/icons/info-big.svg = adblockplusui/skin/icons/info-big.svg

Hints for testers

  • See the hints for testers in the individual adblockplusui issues.
  • Verify that the performance didn't degrade horribly with Firefox versions < 66.
  • Verify that the blocked count updates in real time as the popup window is open in Firefox versions >= 66.
  • Verify that adjusting filter subscriptions and custom filters still works properly.
  • Verify that the issue reporter still records the requests that the webpage made correctly.
  • Verify that whitelisting filters still work correctly, especially more complicated cases like with nested frames.
  • Verify that matches for whitelisting filters still show up in our developer tools panel.
Edited by Thomas Greiner