"abp:day1" link does not work from popup notification
Background
Environment
- reproduced on Chrome 76, Firefox 69, Opera 63 (did not check older browser versions)
- latest ABP development build.
How to reproduce
Trigger a popup notification that contains an abp:day1
link. You can use code below:
{
"notifications": [
{
"id": "day1_popup_link",
"severity": "information",
"links": [
"abp:day1"
],
"title": {
"en-US": "day1 Link Notification",
"de": "DE day1 Link Notification"
},
"message": {
"en-US": "This is a <a>day1</a> notification.",
"de": "DE This is a <a>day1</a> notification."
}
}
],
"version": "201810011538"
}
What to change
- Update the
notifications.clicked
message listener to:- If `message.link is included:
- Call
openNotificationLink
formessage.link
.
- Call
- Otherwise
- Call
browser.notifications.clear
formessage.id
if the browser supports desktop notifications. - Call
notificationDismissed
formessage.id
.
- Call
- If `message.link is included:
- Update the adblockplusui dependency to
hg:TBD git:TBD
.
Observed behaviour
abp:day1
link in the popup notification does not open the day1.html
landing page. Instead, it redirects to https://adblockplus.org/redirect?link=abp:day1&lang=en-US
Expected behaviour
-
abp:day1
link should open theday1.html
landing page in both desktop and popup notifications. - Clicking the link in a desktop notification should dismiss both the popup and desktop notification.
- Clicking the link in a popup notification should dismiss neither.
Edited by Dave Vandyke