Stop focusing the data corruption page
Firefox has an ongoing problem with data corruption since the switch to IndexedDB. For users with corrupted data, we will often show the "your data has been corrupted" page every time the browser starts. This is quite intrusive and has apparently led to users uninstalling the extension.
What to change
Stop focusing the first-run page's tab when it is opened due to data corruption.
- Kai does not recommend this change, but Erez has accepted responsibility for the decision to implement it anyway.
Hints for testers
- First-run page should open and get focus when installing the extension. No error message should be shown.
- First-run page should open and not get focus when reloading the extension after removing all installed filter lists. The filter list warning should be shown.
- First-run page should open and not get focus when reloading the extension after encountering a data corruption issue. The data corruption warning should be shown.
Note that in order to simulate a data corruption issue, I set
let dataCorrupted = true; in adblockpluschrome/lib/subscriptionInit.js during development. I'm not aware of any means to trigger this from outside the extension.