Skip to content

Fixes #387 - Ensure rulesets enabled mechanism

Rowan Deysel requested to merge 387-ensure-enabled-rulesets into master

What's this?

This MR makes sure that the rulesets we have available through the DNR API are aligned with the subscriptions that we're keeping track of in the SDK.

What else?

  • Reloading the extension sets the currently enabled rulesets back to the state they are from the manifest file.
  • Although originally found in the context of enabling an extension to run in incognito mode, the assumption here is that a reload of the extension actually causes the issue.
  • This MR also removes the version check from the onInstalled method. Perhaps something to chat about?
  • This MR adds a test recreating the situation of reloading and checking that subscription items are retained.
Edited by Rowan Deysel

Merge request reports