Skip to content

Fixes #333 - Unable to run subs-generate without calling npm install

Anton Smirnov requested to merge 333-no_validator into master

Remove the "validator" dependency. Implement isUUID() with regexp. Add the tests.

Tested manually:

/tmp/test asmirnov
> cat package.json 
{
  "name": "test",
  "version": "0.5.0",
  "description": "eyeo's Web Extension Ad Blocking Toolkit",
  "repository": {
    "type": "git",
    "url": "https://gitlab.com/eyeo/adblockplus/abc/webext-sdk"
  },
  "author": "eyeo GmbH",
  "license": "GPL-3.0",
  "engines": {
    "node": ">=16.10.0",
    "npm": ">=7"
  },
  "dependencies": {
    "sdk": "git+https://gitlab.com/eyeo/adblockplus/abc/webext-sdk.git#104699fb62cda8e7a2b0502c05a0cbf0de1f2b4d"
  }
}
/tmp/test asmirnov
> 
/tmp/test asmirnov
> 









/tmp/test asmirnov
> npm exec subs-generate
Web extension manifest fragment file (scriptsOutput/rulesets/rulesets.json) generated.
/tmp/test asmirnov
> cat scriptsOutput/rulesets/rulesets.json 
{
  "rule_resources": [
    {
      "id": "03648752-31EE-4FD0-85C1-20B07C5551C3",
      "enabled": false,
      "path": "03648752-31EE-4FD0-85C1-20B07C5551C3"
    },
    {
      "id": "07549D8B-F06F-4D9D-A567-929AA59E9D1D",
      "enabled": false,
      "path": "07549D8B-F06F-4D9D-A567-929AA59E9D1D"
    },
    {
      "id": "0798B6A2-94A4-4ADF-89ED-BEC112FC4C7F",
      "enabled": false,
      "path": "0798B6A2-94A4-4ADF-89ED-BEC112FC4C7F"
    },
    {
      "id": "0A679439-445F-4DE7-84B9-88341F6DA520",
      "enabled": false,
      "path": "0A679439-445F-4DE7-84B9-88341F6DA520"
    },
    {
      "id": "0B0296EB-1CC5-49CD-AD38-8AF27420B7E4",
      "enabled": false,
      "path": "0B0296EB-1CC5-49CD-AD38-8AF27420B7E4"
    },
    {
      "id": "0CD3D105-D3B3-4652-8489-94163DE9A08F",
      "enabled": false,
      "path": "0CD3D105-D3B3-4652-8489-94163DE9A08F"
    },
    {
      "id": "14DF7BE6-9675-4E07-987A-D8A1000F9FEF",
      "enabled": false,
      "path": "14DF7BE6-9675-4E07-987A-D8A1000F9FEF"
    },
    {
      "id": "1638B159-F64A-4307-84E7-16AB08ED409E",
      "enabled": false,
      "path": "1638B159-F64A-4307-84E7-16AB08ED409E"
    },
    {
      "id": "19C949EA-E77F-4250-9068-8FA80EDDEB77",
      "enabled": false,
      "path": "19C949EA-E77F-4250-9068-8FA80EDDEB77"
    },
    {
      "id": "1B5F78CA-8B30-4BDF-B0A3-451CB2202984",
      "enabled": false,
      "path": "1B5F78CA-8B30-4BDF-B0A3-451CB2202984"
    },
    {
      "id": "1C571EC7-6E52-47CC-B04A-4B3008D0AEBE",
      "enabled": false,
      "path": "1C571EC7-6E52-47CC-B04A-4B3008D0AEBE"
    },
    {
      "id": "1D7F590C-B752-4BA0-9473-6A26DE1326B1",
      "enabled": false,
      "path": "1D7F590C-B752-4BA0-9473-6A26DE1326B1"
    },
    {
      "id": "1E7A240E-CD85-493D-BEEF-C68A6AEA1225",
      "enabled": false,
      "path": "1E7A240E-CD85-493D-BEEF-C68A6AEA1225"
    },
    {
      "id": "2090F374-29D9-4202-B2CE-139D6492D95E",
      "enabled": false,
      "path": "2090F374-29D9-4202-B2CE-139D6492D95E"
    },
    {
      "id": "25A31255-AB36-48A4-9086-06192DE71119",
      "enabled": false,
      "path": "25A31255-AB36-48A4-9086-06192DE71119"
    },
    {
      "id": "2708BCB7-2E45-41BC-B517-1730CF532F89",
      "enabled": false,
      "path": "2708BCB7-2E45-41BC-B517-1730CF532F89"
    },
    {
      "id": "2CEA1481-C29C-44F1-A084-A2A019533797",
      "enabled": false,
      "path": "2CEA1481-C29C-44F1-A084-A2A019533797"
    },
    {
      "id": "2D8C4D88-34A0-4259-9098-30D28BA674BC",
      "enabled": false,
      "path": "2D8C4D88-34A0-4259-9098-30D28BA674BC"
    },
    {
      "id": "2F0A4F0D-DF16-40D0-B0E0-5EB6791EC119",
      "enabled": false,
      "path": "2F0A4F0D-DF16-40D0-B0E0-5EB6791EC119"
    },
    {
      "id": "3B85CD3F-553A-45D1-AA38-6288E1C4C7B9",
      "enabled": false,
      "path": "3B85CD3F-553A-45D1-AA38-6288E1C4C7B9"
    },
    {
      "id": "3D2C09D0-DF1C-4C8E-9947-A23DCEAF8F8B",
      "enabled": false,
      "path": "3D2C09D0-DF1C-4C8E-9947-A23DCEAF8F8B"
    },
    {
      "id": "3D60E303-1141-4775-B800-834177922876",
      "enabled": false,
      "path": "3D60E303-1141-4775-B800-834177922876"
    },
    {
      "id": "4337FB2B-A95C-44D5-B78D-11AD40F7711B",
      "enabled": false,
      "path": "4337FB2B-A95C-44D5-B78D-11AD40F7711B"
    },
    {
      "id": "4B6CE485-30AB-4213-AD17-504B3F2D2825",
      "enabled": false,
      "path": "4B6CE485-30AB-4213-AD17-504B3F2D2825"
    },
    {
      "id": "51893C6C-F39E-43C5-A2EF-9545E388A2CE",
      "enabled": false,
      "path": "51893C6C-F39E-43C5-A2EF-9545E388A2CE"
    },
    {
      "id": "5BD2BB73-459D-4A74-AF9D-A10157268350",
      "enabled": false,
      "path": "5BD2BB73-459D-4A74-AF9D-A10157268350"
    },
    {
      "id": "684A25C6-6B5D-458A-8A2B-BAC0A12B0B15",
      "enabled": false,
      "path": "684A25C6-6B5D-458A-8A2B-BAC0A12B0B15"
    },
    {
      "id": "6D489E8D-E61C-444C-BBC5-44741773ADC2",
      "enabled": false,
      "path": "6D489E8D-E61C-444C-BBC5-44741773ADC2"
    },
    {
      "id": "879ECB9D-8935-4506-939E-5BBB7DD09402",
      "enabled": false,
      "path": "879ECB9D-8935-4506-939E-5BBB7DD09402"
    },
    {
      "id": "8C13E995-8F06-4927-BEA7-6C845FB7EEBF",
      "enabled": false,
      "path": "8C13E995-8F06-4927-BEA7-6C845FB7EEBF"
    },
    {
      "id": "8D421590-1A68-4B68-BE50-04E17C09460E",
      "enabled": false,
      "path": "8D421590-1A68-4B68-BE50-04E17C09460E"
    },
    {
      "id": "8E2D687A-3B44-46E1-BE68-2FE5441A788E",
      "enabled": false,
      "path": "8E2D687A-3B44-46E1-BE68-2FE5441A788E"
    },
    {
      "id": "950C88EA-2DD1-42E3-B2A2-2DF2ED15563A",
      "enabled": false,
      "path": "950C88EA-2DD1-42E3-B2A2-2DF2ED15563A"
    },
    {
      "id": "96932CD9-6DDF-4D97-B92F-FDF747B6FAA2",
      "enabled": false,
      "path": "96932CD9-6DDF-4D97-B92F-FDF747B6FAA2"
    },
    {
      "id": "99166908-5FDA-4F9E-8C4C-70BB4DEEFC08",
      "enabled": false,
      "path": "99166908-5FDA-4F9E-8C4C-70BB4DEEFC08"
    },
    {
      "id": "9BD3EA2F-889D-4CC3-B680-CF484F2BD1B9",
      "enabled": false,
      "path": "9BD3EA2F-889D-4CC3-B680-CF484F2BD1B9"
    },
    {
      "id": "9CC3AF4D-EB89-4100-97C6-4EEE4F8A2E82",
      "enabled": false,
      "path": "9CC3AF4D-EB89-4100-97C6-4EEE4F8A2E82"
    },
    {
      "id": "9F743FCD-801B-41D0-830F-5A4EA995216E",
      "enabled": false,
      "path": "9F743FCD-801B-41D0-830F-5A4EA995216E"
    },
    {
      "id": "9FAA2906-CD5C-4520-BDC4-4E098B7EA228",
      "enabled": false,
      "path": "9FAA2906-CD5C-4520-BDC4-4E098B7EA228"
    },
    {
      "id": "A41441EE-BF7C-4A48-9A43-42CCEA2B2A1D",
      "enabled": false,
      "path": "A41441EE-BF7C-4A48-9A43-42CCEA2B2A1D"
    },
    {
      "id": "A4A32212-E6BD-45F6-AD0F-E0FD18E8537B",
      "enabled": false,
      "path": "A4A32212-E6BD-45F6-AD0F-E0FD18E8537B"
    },
    {
      "id": "A4B88FB6-E5E5-417F-8A49-20B8244995FD",
      "enabled": false,
      "path": "A4B88FB6-E5E5-417F-8A49-20B8244995FD"
    },
    {
      "id": "AC6A91D0-3274-45BF-89CA-76FBCEEFECF7",
      "enabled": false,
      "path": "AC6A91D0-3274-45BF-89CA-76FBCEEFECF7"
    },
    {
      "id": "AE0D9320-665E-407D-B692-1A85AE481F34",
      "enabled": false,
      "path": "AE0D9320-665E-407D-B692-1A85AE481F34"
    },
    {
      "id": "B3B79284-DC2C-48B9-8856-AB52A41760A9",
      "enabled": false,
      "path": "B3B79284-DC2C-48B9-8856-AB52A41760A9"
    },
    {
      "id": "B7D76369-DD19-4602-80E8-2E32DDB490AC",
      "enabled": false,
      "path": "B7D76369-DD19-4602-80E8-2E32DDB490AC"
    },
    {
      "id": "BBC07C05-66F1-42EC-BD4D-7AD495FAC84B",
      "enabled": false,
      "path": "BBC07C05-66F1-42EC-BD4D-7AD495FAC84B"
    },
    {
      "id": "BCE2062F-0D99-4861-A1F7-E3DFEA6DAB69",
      "enabled": false,
      "path": "BCE2062F-0D99-4861-A1F7-E3DFEA6DAB69"
    },
    {
      "id": "C3D13A19-3E8D-41F5-AD64-0F3B36DDE128",
      "enabled": false,
      "path": "C3D13A19-3E8D-41F5-AD64-0F3B36DDE128"
    },
    {
      "id": "C8C1AA76-15B4-4CA3-8A9C-AD38D6AFCAEC",
      "enabled": false,
      "path": "C8C1AA76-15B4-4CA3-8A9C-AD38D6AFCAEC"
    },
    {
      "id": "CB94E27D-6CD1-4DB9-83D9-6B7F1A3555F6",
      "enabled": false,
      "path": "CB94E27D-6CD1-4DB9-83D9-6B7F1A3555F6"
    },
    {
      "id": "CBE50FA2-DE3F-480C-B1D7-04289391C033",
      "enabled": false,
      "path": "CBE50FA2-DE3F-480C-B1D7-04289391C033"
    },
    {
      "id": "CDAD4CF5-2706-42CB-B404-F5B9B61B8CAA",
      "enabled": false,
      "path": "CDAD4CF5-2706-42CB-B404-F5B9B61B8CAA"
    },
    {
      "id": "D4028CDD-3D39-4624-ACC7-8140F4EC3238",
      "enabled": false,
      "path": "D4028CDD-3D39-4624-ACC7-8140F4EC3238"
    },
    {
      "id": "D5561090-9ADB-4EEE-AA81-101B645D9F4F",
      "enabled": false,
      "path": "D5561090-9ADB-4EEE-AA81-101B645D9F4F"
    },
    {
      "id": "D72B6F06-52B2-4FED-96A2-1BF59CDD7AEC",
      "enabled": false,
      "path": "D72B6F06-52B2-4FED-96A2-1BF59CDD7AEC"
    },
    {
      "id": "E22C3B40-DC90-49D7-8BF5-E60904AB159A",
      "enabled": false,
      "path": "E22C3B40-DC90-49D7-8BF5-E60904AB159A"
    },
    {
      "id": "E89B3C08-2DED-40EA-8EE1-339B90D7B451",
      "enabled": false,
      "path": "E89B3C08-2DED-40EA-8EE1-339B90D7B451"
    },
    {
      "id": "EEEF75EC-B2B4-49F4-BC49-17B08266F334",
      "enabled": false,
      "path": "EEEF75EC-B2B4-49F4-BC49-17B08266F334"
    },
    {
      "id": "F12E0801-A00B-49DE-B1E3-52C9C4F90C8C",
      "enabled": false,
      "path": "F12E0801-A00B-49DE-B1E3-52C9C4F90C8C"
    },
    {
      "id": "F6CF9D09-0B6B-42D4-9B7C-E62F1D801207",
      "enabled": false,
      "path": "F6CF9D09-0B6B-42D4-9B7C-E62F1D801207"
    }
  ]

Closes #333 (closed)

Edited by Anton Smirnov

Merge request reports