Skip to content

Fix #231 - Broken filter storage in Firefox private mode

Anton Smirnov requested to merge 231-idb_in_private_mode_ff-prefs_in_bsl into master

The io uses IndexedDB or browser.storage.local depending on the availability. The Prefs are stored in browser.storage.local in both regular and private modes. I've added the private/incognito mode support in test runner (documented the cmd-line argument in README) and configured CI to run the private mode tests in 1 Chrome configuration and 1 FF configuration.

Ideally i'd prefer to have automatic tests:

  • for migration case
  • for non-migration case (already migrated)
  • for the old case - the data was in BSL and no migration needed
  • prefs (get, set)

But for now during the dev pairing we agreed that if all the existing test (that were created for regular mode scenario) pass, we're more or less satisfied with it.

No prefs-related test exist at the moment, but probably we could reuse reload test. I've tested it manually and i'd prefer anyone to confirm that independently. Probably @a.czyzewska can help with it (manually or write automated tests).

Closes #231 (closed)

Edited by Anton Smirnov

Merge request reports