Skip to content

Noissue - make custom subscriptions paths consistent

Anton Smirnov requested to merge noissue-consistent_custom_subs_paths into master

The problem: our webpack configuration uses hardcoded path "custom_subscriptions.json" for custom subscriptions file path. It's used to replace the "subscriptions.json" file content from "core", so it's content is used when calling getRecommended() subscriptions.

But in scripts (aka tooling) we're flexible to accept any paths but use "core"'s default paths for custom (generated) subscriptions file.

So we need to use the same custom subscriptions file path for the tooling and webpack config.

This MR achieves it by passing the same file path for the tooling as it's used in webpack.

Blocked by https://gitlab.com/eyeo/adblockplus/abc/webext-sdk/-/merge_requests/333

Edited by Anton Smirnov

Merge request reports