Skip to content

Draft: Fixes EE-361 - Ignore attempts for adding duplicate filters

Thomas Greiner requested to merge ThomasGreiner-eyeo/abp/webext-ad-filtering-solution:ewe_361 into master

This MR contains the following changes:

  • Updated EWE.filters.add() function to ignore duplicate filters.
    • Updated filterStorage.addFilter() and filterStorage.addFiltersWithMetadata() functions to return early instead of throwing, when attempting to add an existing filter again.
    • Removed "storage_duplicate_filters" filter error.
  • Updated documentation accordingly.
  • Updated tests accordingly.
    • Fixed: Testing mechanism test relied on EWE.filters.add() duplicate filter adding behavior for verifying that error handling works as expected.
      • Added "ewe-test:error" messaging endpoint to test extension.
  • Updated release notes accordingly.

This MR also contains the following unrelated changes:

  • Removed redundant await before expect() for consistency with how the function is called in similar test cases.

Marked as Draft while CI pipeline runs all the tests to check whether the implementation works as expected, due to GitLab being unable to run the CI pipeline on the branch (see https://gitlab.com/ThomasGreiner-eyeo/abp/webext-ad-filtering-solution/-/pipelines/1251006353).

Merge request reports