Skip to content

Refs #452 - Allowing providing default subscription in mv3

Hubert Figuière requested to merge issue-452 into master
  • Introduce filterEngine features
  • Handle mv2_url
  • Return RegularSubscriptions for DNR

Things that needs documenting:

  • The filterEngine needs to be initialised with the DNR feature. Pass {feature: Features.DNR} (this is like in !663 (closed)). This will propagate to the filterStorage and subscriptions.
  • The filterEngine get passed the parsed "subscription.json" file when being constructed. Omitting this, like for mv2, uses the default one.
  • Subscription.fromURL() resolve with mv2_url and use the canonical mv3. It returns a RegularSubscription which isn't downloadable, otherwise same. (obsolete some of !662 (closed)) Currently id are ignored.
  • Use Subscription.setFilterText() before adding to the storage to add filters (an array of strings).
Edited by Hubert Figuière

Merge request reports