firstVersion parameter added to downloadable URL instead of to download URL
Environment
- Ubuntu 19.10
- Chromium 79
- Adblock Plus for Chrome (development build)
How to reproduce
- Open Advanced tab in desktop settings page.
- Click on "Update all filter lists" button.
- Reload settings page.
Observed behavior
- After step 2) Nothing happens.
- After step 3) Old download dates shown.
Expected behavior
- After step 2) "Last updated" column should indicate download status while it's ongoing and after it finished (i.e. show error message or later date).
- After step 3) New download dates shown.
Further information
This regression appears to have been introduced by the recent introduction of the firstVersion
parameter in filter list downloads (see #83 (closed)). Instead of appending it in Downloader.prototype.getDownloadUrl()
we instead do that in Synchronizer.prototype._getDownloadable()
. Thereby we overwrite the URL that lets us identify the filter list (e.g. when notifying various parts of the extension of its state changes). We should instead append the parameter alongside the other download parameters in Downloader.prototype.getDownloadUrl()
in order to prevent breakage.
Originally reported as ui#659.
Edited by Thomas Greiner