Skip to content

Add new share goal to orchestration

Kyle Tee requested to merge LordParsley/exosphere:feature/share-goal into master

Overview

Fixes #969 (closed).

When creating a new share, we wish to create a default access rule for it.

But the share is not immediately available, & if the create access rule request is dispatched too soon, it can fail.

This change:

  • Adds a new share goal to the project orchestration.
  • Polls for shares if there are any that are both new & have no access rules.
  • Once a new share's state is available & has no access rules, it dispatches a create access rule request.

How to Test

  • Create a new share & check that a default access rule is created successfully.
  • Use the network inspector to verify that only one create access rule request is sent per new share.
  • Comment on the polling parameters 🙏
  • Is there a case for slow-polling for shares even if there are no new ones? 📝

Screenshots

Please see screen recording below. You can see the interim "Queued to apply" state of the new access rule at ~5 seconds in.

Screen_Recording_2024-03-13_at_15.30.07

Merge request reports