Skip to content

Add elm-review rule NoUnused.Patterns

Frank Tackitt requested to merge kageurufu/exosphere:elm-review/NoUnused.Patterns into master

Overview

Add elm-review rule NoUnused.Patterns

This rule detects unused variables in patterns and unnecessary patterns

For example

case (True, False) of
    (True, n) -> True    -- n is unused
    (_, _) -> False      -- Tuple match could be just _
-- ELM-REVIEW ERROR ---------------------------------- src/State/State.elm:570:9

(fix) NoUnused.Patterns: Tuple pattern is not needed

570|         ( _, _ ) ->
                ^^^^^^^^
571|             -- This is not great because it allows us to forget to write a case statement above, but I don't know of a nicer way to write a catchall case for when a page-specific Msg is received for an inapplicable page.

This pattern is redundant and should be replaced with '_'.

Discussion

This is an easy rule with auto-fixes, and I don't see any real issues it would cause

Merge request reports