Skip to content

Draft: (very raw!). Use a different data structure for project.images so as to not make unneeded requests when requesting images.

James Carlson requested to merge jxxcarlson/exosphere:jim-886 into master

Overview

The current type for project.images is

images : RDPP.RemoteDataPlusPlus HttpErrorWithBody (List OSTypes.Image)

I've changed this to

images : List ( OSTypes.ImageVisibility, RDPP.RemoteDataPlusPlus HttpErrorWithBody (List OSTypes.Image) )

after a failed experiment to have project.publicImages, project.privateImages, etc. Having separate lists proved to be so cumbersome that I gave up, hence the new type above.

I am posting this very raw draft to get some comment on the new type. Is it reasonable? A major refactor was needed to get the app to compile and display images. There remains a good bit of work to do.

I building this on top of the jim-datalist branch since for testing I needed a good way to view the number of images received (filtered and unfiltered).

Fixes #886

How to Test

Not ready to test yet.

Screenshots

No visual changes

Merge request reports