Fixup from !562
If user has attempted to delete server, show this in server UI status, not separately in delete widget
This means a deleting server now shows "Deleting" in the preview tile on the project overview page.
Commit a06d9c08 introduced a default server sort order of descending creation time in the two places where we render a list of servers. This sort order is good, but when we updated the model with servers from the API (in Helpers.GetterSetters.ProjectUpdateServer), we were still sorting by server name (alphabetically). We were not using that sort order anywhere that I could find.
This commit simplifies the codebase by:
- Changing the sort order in the model (Helpers.GetterSetters.ProjectUpdateServer) from alphabetical-by-name to descending creation time
- Removing the sorting logic in the rendering code (pages)
Tip for reviewers: un-check "Show whitespace changes" when reviewing /srv/View/Helpers.elm
. It's a 3-line change, not an 88-line change.
How to Test
-
Delete a server, go to Project Overview page, see it say "Deleting"
-
No functional changes to app; confirm servers are displayed in descending order of creation time.
Screenshots
QA Checklist
-
Any changes to 'widgets' in src/Style/Widgets/
? If so:- Update
src/Style/StyleGuide.elm
showing example usage of that widget
- Update
-
Were any app flags created, modified, or removed? If so: - Update
config.js
and all files inenvironment-configs/
, includingdocker-config.js
- Update "Runtime configuration options" documentation in README.md
- Update
Post-Merge Checklist
-
Create follow-up issues for anything left over for another merge request - If any technical debt is introduced, assign these follow-up issues to the MR submitter