Skip to content
Snippets Groups Projects

Add DOI repositories, URL/file paths, and references

This MR builds on !449 (merged) to introduce:

  • Support for DOI repositories (in addition to Git repositories)
  • Ability to specify a Git reference
  • Ability to specify a URL path (for example /rstudio, which is needed for transparent support of RStudio-based repositories)
  • Removed the big 'experimental' warning, and added a 'BETA' label instead

In the process I simplified the custom workflow code introduced by !449 (merged). In particular I removed dead code paths and unused types.

Fixes #564 (closed)

How to Test

  • Try starting an RStudio-based, Figshare DOI:
    • Paste the following in the Git repository URL or DOI input: 10.6084/m9.figshare.9782777.v1
    • Paste the following in the URL to open e.g. /rstudio input: /rstudio
    • This should succeed, and when you click on the workflow interaction button a tab with RStudio should open
  • Try starting a workflow from a particular branch on a GitHub repository
    • Paste the following in the Git repository URL or DOI input: https://github.com/binder-examples/minimal-dockerfile
    • Paste the following in the Git ref (branch, tag, or commit) input: betatim-patch-1
  • Make sure you can't launch an invalid workflow
    • Specify a reference and/or path, but with an empty repository URL or DOI
    • The server 'Create' button should be disabled
    • Enter something into the repository URL or DOI input
    • The server 'Create' button should now be enabled
  • Ensure that the 'Remove workflow' button still functions
    • This button should be enabled/clickable when there is anything entered in any of the three input fields
    • Check that button is enabled for both valid and invalid workflows
    • Ensure that pressing the 'Remove workflow' button clears the workflow input fields in both invalid and valid workflow cases

Screenshots

Screen_Shot_2021-09-07_at_19.37.28

See https://youtu.be/07t9pTtoCxM for a demo.

QA Checklist

  • Any changes to 'widgets' in src/Style/Widgets/? If so:
    • Update src/Style/StyleGuide.elm showing example usage of that widget
  • Were any app flags created, modified, or removed? If so:
    • Update config.js and all files in environment-configs/, including docker-config.js
    • Update "Runtime configuration options" documentation in README.md

Post-Merge Checklist

  • Create follow-up issues for anything left over for another merge request
    • If any technical debt is introduced, assign these follow-up issues to the MR submitter
Edited by Julian Pistorius

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Julian Pistorius added 6 commits

    added 6 commits

    • 7abe4ca4 - Clarify that option is for source providers
    • 7f52ba07 - Use plain text as label for source input
    • 3497659a - Use real label for source input
    • b34d4f90 - Moved reference input to its own function
    • 92d487cd - Set entered repository reference on model
    • 727cc745 - Enter repository path, and set it on the model

    Compare with previous version

  • Julian Pistorius added 9 commits

    added 9 commits

    • e4fdd1dc - Removed defaultProvider and providers.
    • a52b1c45 - Removed SourceProvider
    • 91a65666 - Collapsed FilePath and UrlPath into a single type
    • 5615c987 - Removed providerPrefix, pathType from SourceInput
    • e65ce42c - Use type aliases instead of strings in SourceInput
    • b192f08c - Removed CustomWorkflowSourceRepository type
    • 591aecf7 - Revert "Added a dropdown without a label"
    • 9c3aed9b - Renamed GotCustomWorkflowSource
    • 1239a827 - Use type aliases for workflow input components

    Compare with previous version

  • Julian Pistorius added 2 commits

    added 2 commits

    • eb52807c - Replaced workflows warning with 'BETA' label
    • 0548556b - Convert workflow input into a workflow

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • Julian Pistorius resolved all threads

    resolved all threads

  • Julian Pistorius added 2 commits

    added 2 commits

    • 7f1ddee8 - Added a toggle tip to explain Binder connection
    • dccfc0a0 - Launch workflow with path specified by user

    Compare with previous version

  • Julian Pistorius marked this merge request as ready

    marked this merge request as ready

  • Julian Pistorius changed the description

    changed the description

  • assigned to @cmart and unassigned @julianpistorius

  • Julian Pistorius approved this merge request

    approved this merge request

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading