Add DOI repositories, URL/file paths, and references
Merged
requested to merge julianpistorius/exosphere:issue-564-workflows-doi-paths-and-refs into master
This MR builds on !449 (merged) to introduce:
- Support for DOI repositories (in addition to Git repositories)
- Ability to specify a Git reference
- Ability to specify a URL path (for example
/rstudio
, which is needed for transparent support of RStudio-based repositories) - Removed the big 'experimental' warning, and added a 'BETA' label instead
In the process I simplified the custom workflow code introduced by !449 (merged). In particular I removed dead code paths and unused types.
Fixes #564 (closed)
How to Test
- Try starting an RStudio-based, Figshare DOI:
- Paste the following in the
Git repository URL or DOI
input:10.6084/m9.figshare.9782777.v1
- Paste the following in the
URL to open e.g. /rstudio
input:/rstudio
- This should succeed, and when you click on the workflow interaction button a tab with RStudio should open
- Paste the following in the
- Try starting a workflow from a particular branch on a GitHub repository
- Paste the following in the
Git repository URL or DOI
input:https://github.com/binder-examples/minimal-dockerfile
- Paste the following in the
Git ref (branch, tag, or commit)
input:betatim-patch-1
- Paste the following in the
- Make sure you can't launch an invalid workflow
- Specify a reference and/or path, but with an empty repository URL or DOI
- The server 'Create' button should be disabled
- Enter something into the repository URL or DOI input
- The server 'Create' button should now be enabled
- Ensure that the 'Remove workflow' button still functions
- This button should be enabled/clickable when there is anything entered in any of the three input fields
- Check that button is enabled for both valid and invalid workflows
- Ensure that pressing the 'Remove workflow' button clears the workflow input fields in both invalid and valid workflow cases
Screenshots
See https://youtu.be/07t9pTtoCxM for a demo.
QA Checklist
-
Any changes to 'widgets' in src/Style/Widgets/
? If so:- Update
src/Style/StyleGuide.elm
showing example usage of that widget
- Update
-
Were any app flags created, modified, or removed? If so: - Update
config.js
and all files inenvironment-configs/
, includingdocker-config.js
- Update "Runtime configuration options" documentation in README.md
- Update
Post-Merge Checklist
-
Create follow-up issues for anything left over for another merge request - If any technical debt is introduced, assign these follow-up issues to the MR submitter
Edited by Julian Pistorius
Merge request reports
Activity
assigned to @julianpistorius
added 7 commits
-
629dae17...c171a780 - 6 commits from branch
exosphere:master
- e2549af4 - First attempt at a more complete workflow input
-
629dae17...c171a780 - 6 commits from branch
added 7 commits
-
9b260999 - 1 commit from branch
exosphere:master
- ab2868ed - First attempt at a more complete workflow input
- 08816852 - Select onChange now takes a 'Maybe Value'
- 14d6ed9c - Use human-readable label for the repo source type
- bb86ef75 - Added a dropdown without a label
- e9238488 - Use List of tuples for providers, instead of Dict
- d3a3d805 - Don't show 'Repository source' label in dropdown
Toggle commit list-
9b260999 - 1 commit from branch
added 1 commit
- a18d98dd - Now able to select the type of repository provider
added 53 commits
-
a18d98dd...a3b3e3a7 - 46 commits from branch
exosphere:master
- 7fd98709 - First attempt at a more complete workflow input
- 0d2fa806 - Select onChange now takes a 'Maybe Value'
- 076d22c8 - Use human-readable label for the repo source type
- 5ac3da90 - Added a dropdown without a label
- 14db09f8 - Use List of tuples for providers, instead of Dict
- 49a7943e - Don't show 'Repository source' label in dropdown
- 9ff3bb6c - Now able to select the type of repository provider
Toggle commit list-
a18d98dd...a3b3e3a7 - 46 commits from branch
- Resolved by Julian Pistorius
added 6 commits
- 7abe4ca4 - Clarify that option is for source providers
- 7f52ba07 - Use plain text as label for source input
- 3497659a - Use real label for source input
- b34d4f90 - Moved reference input to its own function
- 92d487cd - Set entered repository reference on model
- 727cc745 - Enter repository path, and set it on the model
Toggle commit listadded 9 commits
- e4fdd1dc - Removed defaultProvider and providers.
- a52b1c45 - Removed SourceProvider
- 91a65666 - Collapsed FilePath and UrlPath into a single type
- 5615c987 - Removed providerPrefix, pathType from SourceInput
- e65ce42c - Use type aliases instead of strings in SourceInput
- b192f08c - Removed CustomWorkflowSourceRepository type
- 591aecf7 - Revert "Added a dropdown without a label"
- 9c3aed9b - Renamed GotCustomWorkflowSource
- 1239a827 - Use type aliases for workflow input components
Toggle commit listassigned to @cmart and unassigned @julianpistorius
- Resolved by Julian Pistorius
- Resolved by Julian Pistorius
Please register or sign in to reply