Skip to content

[CM-3176] Possible fix for credential disappearance

Khagesh Sharma requested to merge possible-disappearing-cred into main

Reason for Pull Request

  • Bug fix

Link for jira ticket

CM-3176

Root cause

  • There are two different status for claimRequestStatus that signifies that credential request was successful. We were always checking for only one status. This alone was not the problem because ultimately the credential request should fall in this status. However due to async nature of storage, sometimes storage success was overriding the send_success status and hence we were not picking that particular accepted credential.

High level description of changes done

  • Removed connected component for MyCredentials screen so that we rely on only one way to render component. We are now using only hooks based data selection and not HOC
  • Store selector now checks for both the states while picking accepted credentials
  • Reset events in claim-offer-store's reducer now checks for success states. Before resetting the state it will check if claim request is already in success state, if yes, then state won't reset. So even if by chance the credential offer screen shows up again, we won't reset previous success state.

Merge request reports