Resolve "Use DataTree instead of ScopeSim to store internal data in Scene"
Merge request check list
This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes. But please read our contribution guide at least once, it will save you unnecessary review cycles !
If an item doesn't apply to your merge request, check it anyway to make it apparent that there's nothing to do.
-
Closes issue #645 (closed) -
Added tests for change code -
Updated documentation for changed code -
If a model is added/updated/removed then -
Update documentation references/models -
Update documentation background/detectors/CCD -
Update documentation background/detectors/CMOS -
Update the JSON Schema of Pyxel by typing tox -e json_schema
. - ...
-
-
Documentation .rst
files is written using semantic newlines -
User visible changes (including notable bug fixes and possible deprecations) are documented in CHANGELOG.md
-
Passes in this order -
isort .
orpre-commit run -a
(preferred way) -
black .
orpre-commit run -a
(preferred way) -
blackdoc .
orpre-commit run -a
(preferred way) -
mypy .
ortox -e mypy
ortox -p
(preferred way) -
flake8 .
ortox -e flake8
ortox -p
(preferred way)
-
If you have any questions of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing !
Edited by Frederic Lemmel