second persistence model in charge_collection
Merge request check list
This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes. But please read our contribution guide at least once, it will save you unnecessary review cycles !
If an item doesn't apply to your merge request, check it anyway to make it apparent that there's nothing to do.
- [-] Closes issue #66 - It does not close the issue since there is another more complex model that can be developed.
-
Added tests for change code -
Updated documentation for changed code -
Documentation .rst
files is written using semantic newlines -
User visible changes (including notable bug fixes and possible deprecations) are documented in CHANGELOG.rst
-
Passes in this order -
isort . -
black . -
blackdoc . -
mypy . -
flake8 .
-
If you have any questions of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing !
The new model uses two maps to work: a trap density map and a trap per unit of full well map. Principle stays the same, memory of the detector stores the trapped charges and they are release on subsequent dark exposure. See pyxel-data/examples/dynamic for an example based on MOONS H4RG ENG grade detector