Skip to content

Fixed broken build

Victor Engmark requested to merge Zearin:feature/fix_broken_build into master

Created by: Zearin

I am an idiot

Previously, I was running test/test_package.py all by itself. Since I saw no errors, I assumed there were no problems.

Of course, there is no if __name__ == '__main__': ... in test_package.py. So when I ran it, Python was loading the tests, doing nothing, and exiting.

/facepalm

Where my idiocy came from

I’m not familiar unittest. (I prefer PyVows.) For that matter, I’m not familiar with Distribute; I’ve never published to PyPI.

However…I am sufficiently embarrassed to remember this lesson well. ☺

But the build is all better now

$ ./setup.py test
running test
running egg_info
writing requirements to vcard.egg-info/requires.txt
writing vcard.egg-info/PKG-INFO
writing top-level names to vcard.egg-info/top_level.txt
writing dependency_links to vcard.egg-info/dependency_links.txt
writing entry points to vcard.egg-info/entry_points.txt
reading manifest file 'vcard.egg-info/SOURCES.txt'
writing manifest file 'vcard.egg-info/SOURCES.txt'
running build_ext
test_doc (test.test_package.TestVCards)
Run DocTests ... ok
test_failing (test.test_package.TestVCards)
vCards with errors ... ok
test_online (test.test_package.TestVCards)
vCards in references which are invalid ... ok
test_valid (test.test_package.TestVCards)
Valid (but not necessarily sane) vCards ... ok

----------------------------------------------------------------------
Ran 4 tests in 2.127s

OK

Merge request reports