Skip to content

Removed default values in function signatures for non-last parameters.

Alexey Zinchenko requested to merge Prominence/phonetrack-oc:issue-400 into master

Hello. I've faced with the same problem as described in #400.

My log:

Required parameter $gprmc follows optional parameter $devicename at /var/www/html/custom_apps/phonetrack/lib/Controller/LogController.php#1969

Seeing issue isn't being fixed, I tried to do it on my own. I'm not familiar with PHP and its syntax, but the problem seems not to be hard.

I haven't found any explicit invocations of these methods without value in $devicename parameter, so I just removed default value from the signature. (Hope there won't be any side-effects.)

I tested these changes on my own installation. It fixes the error on Logging tab, but my phone app(PhoneTrack) still shows an error:

Uploading failed:
Server response error

After, I checked it in µlogger app and it works fine. But I hope, you'll also fix the problem in your own app(if it is not a problem on my side).

Versions:

  • Nextcloud: 22.2.3
  • PHP: 8.0.13
  • PhoneTrack: 0.1.0

Thanks in advance!

Edited by Alexey Zinchenko

Merge request reports